Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger]Add hidden attribute support #61143

Merged
merged 7 commits into from
Nov 3, 2021
Merged

[wasm][debugger]Add hidden attribute support #61143

merged 7 commits into from
Nov 3, 2021

Conversation

ilonatommy
Copy link
Member

Adds support for System.Diagnostics.DebuggerHiddenAttribute - #57085.

@ilonatommy
Draft of hidden attribute decorator use.
5e92d39
@ilonatommy
Removed checking custom attributes in the runtime each time the break…
8c44fae 
…point is set and moved it to the constructor which is more efficient.
@ilonatommy
Added test for DebuggerHidden decorator.
5302e15
@ilonatommy
By adding a line: using System.Diagnostics; IntAdd method moved down …
01e5e83 
…one line what resulted in CreateGoodBreakpoint tests failures. All row numbers in these tests had to be incremented.
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 3, 2021
@ilonatommy ilonatommy self-assigned this Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds support for System.Diagnostics.DebuggerHiddenAttribute - #57085.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy requested review from thaystg and removed request for marek-safar November 3, 2021 11:06
@thaystg thaystg changed the title Add hidden attribute support [wasm][debugger]Add hidden attribute support Nov 3, 2021
@ilonatommy ilonatommy merged commit 39f3470 into dotnet:main Nov 3, 2021
@ilonatommy ilonatommy deleted the add-hidden-attribute-support branch November 3, 2021 13:17
@ilonatommy ilonatommy restored the add-hidden-attribute-support branch November 3, 2021 15:34
@ilonatommy ilonatommy mentioned this pull request Nov 3, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marek-safar marek-safar marek-safar left review comments

@thaystg thaystg thaystg approved these changes

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @marek-safar @thaystg