Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger]Add hidden attribute support #61143

Merged
merged 7 commits into from
Nov 3, 2021
Merged

[wasm][debugger]Add hidden attribute support #61143

merged 7 commits into from
Nov 3, 2021

Commits on Nov 2, 2021

  1. Draft of hidden attribute decorator use.

    @ilonatommy
    ilonatommy committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    5e92d39 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Removed checking custom attributes in the runtime each time the break… 

    …point is set and moved it to the constructor which is more efficient.
    @ilonatommy
    ilonatommy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    8c44fae View commit details
    Browse the repository at this point in the history

  2. Added test for DebuggerHidden decorator.

    @ilonatommy
    ilonatommy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    5302e15 View commit details
    Browse the repository at this point in the history

  3. By adding a line: using System.Diagnostics; IntAdd method moved down … 

    …one line what resulted in CreateGoodBreakpoint tests failures. All row numbers in these tests had to be incremented.
    @ilonatommy
    ilonatommy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    01e5e83 View commit details
    Browse the repository at this point in the history

  4. Reverted edition of tests not connected with HiddenAttribute.

    @ilonatommy
    ilonatommy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    f021822 View commit details
    Browse the repository at this point in the history

  5. Added visible method to the HiddenAttribute test.

    @ilonatommy
    ilonatommy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    74d27f8 View commit details
    Browse the repository at this point in the history

  6. Applying thaystg review suggestion.

    @ilonatommy
    ilonatommy committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    3deab4b View commit details
    Browse the repository at this point in the history