Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-22928 Add ImmutableArray Span-based APIs #61196

Merged
merged 29 commits into from
Feb 10, 2022
Merged

issue-22928 Add ImmutableArray Span-based APIs #61196

merged 29 commits into from
Feb 10, 2022

Conversation

lateapexearlyspeed
Copy link
Contributor

Fix #22928: Add ImmutableArray Span-based APIs
Will mark it as ready for review when it is ready, thanks.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 4, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #22928: Add ImmutableArray Span-based APIs
Will mark it as ready for review when it is ready, thanks.

Author: lateapexearlyspeed
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation
Milestone: -

@lateapexearlyspeed lateapexearlyspeed mentioned this pull request Nov 4, 2021
Closed
This was referenced Nov 4, 2021
Closed
Closed
@eiriktsarpalis eiriktsarpalis self-assigned this Nov 30, 2021
@runfoapp runfoapp bot mentioned this pull request Dec 3, 2021
Closed
@lateapexearlyspeed lateapexearlyspeed marked this pull request as ready for review December 17, 2021 03:18
@lateapexearlyspeed
Copy link
Contributor Author

Hi @eiriktsarpalis , this PR is ready for review now, thanks !

@lateapexearlyspeed
Fix comment: Use new CollectionsMarshal methods to get and update val…
fb1dd63 
…ue in Dictionary; split netcoreapp RemoveRange and non-netcoreapp RemoveRange().
@lateapexearlyspeed
Copy link
Contributor Author

lateapexearlyspeed commented Feb 7, 2022 •
edited
Loading

Hi @eiriktsarpalis any chance to have a look at comment ? That is to explain:

Why would we need the slow path when a non-default equality comparer has been supplied? (link)

@eiriktsarpalis
Copy link
Member

@lateapexearlyspeed see #61196 (comment)

@lateapexearlyspeed
Copy link
Contributor Author

@lateapexearlyspeed see #61196 (comment)

@eiriktsarpalis Replied in comment.

@lateapexearlyspeed
Copy link
Contributor Author

@eiriktsarpalis All comments should have been discussed or addressed now, please check.

@eiriktsarpalis eiriktsarpalis mentioned this pull request Feb 9, 2022
Open
eiriktsarpalis
eiriktsarpalis approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few minor changes LGTM.

@eiriktsarpalis eiriktsarpalis merged commit cf35d12 into dotnet:main Feb 10, 2022
@eiriktsarpalis
Copy link
Member

Thanks @lateapexearlyspeed!

@lateapexearlyspeed lateapexearlyspeed mentioned this pull request Feb 22, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Add ImmutableArray Span-based APIs
3 participants
@lateapexearlyspeed @eiriktsarpalis @stephentoub