Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-22928 Add ImmutableArray Span-based APIs #61196

Merged
merged 29 commits into from
Feb 10, 2022
Merged

issue-22928 Add ImmutableArray Span-based APIs #61196

merged 29 commits into from
Feb 10, 2022

Commits on Nov 4, 2021

  1. issue-22928 Initial commit: AddRange, InsertRange, ToImmutableArray, … 

    …Create.
    @lateapexearlyspeed
    lateapexearlyspeed committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    f0c9ca8 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. issue-22928 CopyTo, RemoveRange, Slice. Skip old tests.

    @lateapexearlyspeed
    lateapexearlyspeed committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    4ce2f25 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Eliminate range based method compilation for .netstandard2.0 and net461.

    @lateapexearlyspeed
    lateapexearlyspeed committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    10ed570 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. issue-22928 Refine to use common code.

    @lateapexearlyspeed
    lateapexearlyspeed committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    89810ad View commit details
    Browse the repository at this point in the history

  2. Try to use <framework>_OR_GREATER pre-compilation symbol.

    @lateapexearlyspeed
    lateapexearlyspeed committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    4f1ef20 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. issue-22928 Test cases of ImmutableArray.Create() overloads.

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    6691eda View commit details
    Browse the repository at this point in the history

  2. issue-22928 Add test cases for ImmutableArray.ToImmutableArray(), Imm… 

    …utableArray.AddRange().
    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    b46c0af View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Test cases for AsSpan(start, length).

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    3144366 View commit details
    Browse the repository at this point in the history

  2. Test cases of AsSpan(Range).

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    d0571c4 View commit details
    Browse the repository at this point in the history

  3. Test cases of ImmutableArray.CopyTo().

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    1516ed0 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Test cases of InsertRange().

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    c8e2b68 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Test cases of RemoveRange().

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    7fd7041 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Add test cases of .Slice().

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1f67b98 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Add test cases of Builder.CopyTo() and Builder.AddRange().

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    f10ae91 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Add xml doc for AsSpan(Range) method.

    @lateapexearlyspeed
    lateapexearlyspeed committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    4078a17 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Fix comment: refine test cases; adjust method list order; add Debug.A… 

    …ssert().
    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    932e731 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Fix comment: move tfm specific code into separate tfm files.

    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    c4384df View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Fix ValidateDefaultThisBehavior() logic issue.

    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    c470255 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Fix comment: use compile condition: $(TargetFrameworkIdentifier)' == … 

    …'.NETCoreApp'.
    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    b29f105 View commit details
    Browse the repository at this point in the history

  2. Fix comment: specify actual data length when construct span.

    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    d98e0d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Change RemoveRange(ReadOnlySpan) to be O(M+N) implementation.

    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    50e278d View commit details
    Browse the repository at this point in the history

  2. Fix comment: refine xml doc.

    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    ba0fa13 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Fix comment: Use new CollectionsMarshal methods to get and update val… 

    …ue in Dictionary; split netcoreapp RemoveRange and non-netcoreapp RemoveRange().
    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    fb1dd63 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Fix comment: refine RemoveRange() to use 'continue'.

    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    7441ab9 View commit details
    Browse the repository at this point in the history

  2. Fix comment: merge 2 tfm version RemoveRange() back to ImmutableArray… 

    …_1.cs.
    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    f1d1d34 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. Add some demo-used test cases to indicate (null & custom equalityComp… 

    …arer) case issue for new RemoveRange().
    @lateapexearlyspeed
    lateapexearlyspeed committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    5366414 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Revert "Change RemoveRange(ReadOnlySpan) to be O(M+N) implementation." 

    This reverts commit 50e278d.
    @lateapexearlyspeed
    lateapexearlyspeed committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    1460a51 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Fix comment: use explicit type name; enhance RemoveRange test cases t… 

    …o cover 'null' case.
    @lateapexearlyspeed
    lateapexearlyspeed committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    85ebef4 View commit details
    Browse the repository at this point in the history

  2. Use explicit type names.

    @lateapexearlyspeed
    lateapexearlyspeed committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    1bb557c View commit details
    Browse the repository at this point in the history