Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete null comparisons of non-null arguments #64435

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Jan 28, 2022

non-null args comparisons were earlier deleted in coreclr, this is to fix remaining GCC warnings in NativeAOT.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 28, 2022
@ghost
Copy link

ghost commented Jan 28, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

non-null args comparisons were earlier deleted in coreclr, this is to fix remaining GCC warnings in NativeAOT.

Author: am11
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution

Milestone: -

@am11 am11 force-pushed the feature/native/gcc-build branch from 65f8c01 to 13e9814 Compare January 28, 2022 08:13
@am11
Copy link
Member Author

am11 commented Jan 28, 2022

cc @jkotas, arm test failure is unrelated (possibly #60825).

@jkotas jkotas merged commit 88b63d1 into dotnet:main Jan 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants