Fix pal_assert.h when PAL_STDCPP_COMPAT defined

[kant2002]

Improves #37310

[kant2002]

I prefer to fix mentioned issue in piecemeal fashion, so this is to check if I understand ropes properly. Mentioned issue important for NativeAOT-LLVM, so you can this about this as of the rationale for this PR.

[jkotas]

Yes, this looks good.

[jkotas]

The profiler test failures seem to be caused by the change in this PR.

[kant2002]

I need advice. Errors coming from https://github.com/dotnet/runtime/blob/d4f06a9c524819dfd1345745a17b3cc6e060ba8b/src/coreclr/inc/corhlpr.cpp where _ASSERTE is used. _ASSERTE require me to link to corepal which seems to be not an option for tests.

Personally I would favor link to corepal in this particular test, but modifying CMakeLists.txt without some dity hacks is not trivial for me in this specific case.

[kant2002]

My understanding that PAL is source level component which does not have physical representation on the disk. Adding files from PAL to tests seems to be too much.

[mangod9]

Hi @kant2002, thanks for your contribution appears that there are still CI failures with this change. Do you plan on investigating further?

[kant2002]

Hi @kant2002, thanks for your contribution appears that there are still CI failures with this change. Do you plan on investigating further?

Yes. Thanks for remind me about that PR

[mangod9]

@kant2002, gentle ping again.

[kant2002]

Thank you @mangod9 ! Without that ping, I would probably again forgot about this PR.