Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pal_assert.h when PAL_STDCPP_COMPAT defined #64631

Merged
merged 10 commits into from
Apr 14, 2022
Merged

Fix pal_assert.h when PAL_STDCPP_COMPAT defined #64631

merged 10 commits into from
Apr 14, 2022

Commits on Apr 12, 2022

  1. Fix pal_assert.h for PAL_STDCPP_COMPAT 

    Improves dotnet#37310
    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    863e46d View commit details
    Browse the repository at this point in the history

  2. Remove _ASSERTE from tests 

    This is pickup _ASSERTE from PAL which is not what it is desired.
    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    f7272c6 View commit details
    Browse the repository at this point in the history

  3. Add workaround for _ASSERTE

    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    ec77c1f View commit details
    Browse the repository at this point in the history

  4. Another try.

    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    4ce80da View commit details
    Browse the repository at this point in the history

  5. One more try

    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    021a39c View commit details
    Browse the repository at this point in the history

  6. Use assert from C++ lib in corhlpr.cpp

    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    38483e1 View commit details
    Browse the repository at this point in the history

  7. Replace _ASSERTE to assert in corhlpr.h

    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    437ca53 View commit details
    Browse the repository at this point in the history

  8. Temporary ask for header inclusion tree during compilation

    @kant2002
    kant2002 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    12319cc View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Remove debug message

    @kant2002
    kant2002 authored Apr 13, 2022
    Configuration menu
    Copy the full SHA
    ade3c47 View commit details
    Browse the repository at this point in the history

  2. Attempt to disable ASSERTE in the ilrewriter.cpp

    @kant2002
    kant2002 authored Apr 13, 2022
    Configuration menu
    Copy the full SHA
    3fc1a08 View commit details
    Browse the repository at this point in the history