-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving "Generic Math" in box and making it no longer experimental #65731
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/area-system-numerics Issue Detailsnull
|
Marking as blocked until we confirm this won't break WPF. CC. @jeffhandley |
020af9d
to
105bdf0
Compare
Rebased to remove conflict |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as resolved.
This comment was marked as resolved.
@akoeplinger could you please check/confirm if the mono failures here are related to Static Abstracts in Interfaces? |
The android failures look infra related and the wasm ones I believe are flaky. Not sure about the windows build failure:
|
It was hit on the rolling build as well - #66380 |
@steveisok, any way we could confirm this? I'd prefer to not have to back this out after merging since its unblocking a lot of work related to generic math and it shipping in .NET 7. Most of the failures look to be showing up as:
Also seeing a few failures like
And then for WASM: |
@tannergooding I'm aware of both problems and they are unrelated to your change. |
Thanks! @agocke, @marek-safar, @jeffhandley are there any other tests or things that could block this from merging on your end? Everything looks to be passing with the Mono failures being unrelated as indicated above. I don't see any of the tests disabled for NAOT/Mono under https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets either. |
Likewise don't see any disablement here. Notably the tests also moved from |
We'll hold off on merging this until VS 17.2 Preview 2 is available. 🔜 |
Merging as per offline conversation with @jeffhandley. Now that VS 17.2 Preview 2 is publicly available and contains the C++/CLI fixes, external contributors will no longer be blocked. dotnet/arcade#8633 tracks the helix support and should only impact WPF for our known dependents. |
Visual Studio 17.2 Preview 2 is available here: |
…tnet#65731) * Moving "Generic Math" in box and making it no longer experimental * Removing an unused using from the generic math interfaces * Updating the ordering of the checked keyword for the commented out checked operators
This is pending WPF uptaking a new C++/CLI toolset so they won't break when encountering types that have static abstract interfaces.
This is just moving the preview surface area to be non-preview, it is explicitly not the "final shape" for many of the interfaces and APIs.