-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condition Windows SslCertificateTrust test on Registry value #65848
Condition Windows SslCertificateTrust test on Registry value #65848
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones |
|
||
if (IsWindows) | ||
{ | ||
// Sending TrustedIssuers is conditioned on the registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Windows7 sends the list by default. e.g. even without registry. There are some test that condition on Windows7 but they really should use this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use different default values depending if we are running on Windows7 or not, so we should be okay here, unless sending cert issuer list can't be disabled on Windows7 using the registry key below.
Do you know if all tests pass now when |
I tried only tests in System.Net.Security, and one of the EKU certificate tests was failing, the cert was filtered out because it did not match any of the issuers. I think it was |
I will have to approach it a bit differently, tests fail on Windows7 because it does not support specifying custom trust store
|
There are two parts IMHO. |
Should we also throw on Windows if sending is not enabled using the registry? That way we would have to check registry at runtime, which we are not doing for any feature AFAIK |
e9ab8f0
to
8656a0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wfurt can you answer my question from #65848 (comment), please? |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
I would be in favor to throw in product as well if it is not enabled in registry to make it visible. Would that be any problem for AAD @avparuch? (e.g. do you have code that expect. ti send the list but the the registry is not set?) |
CI failures are #66100 |
PR for updating docs: dotnet/dotnet-api-docs#7832 |
…65848) Sending trusted issuers list on Windows is problematic (depends on registry settings), so there were no tests. This PR conditionally enables existing tests on Windows if the relevant registry setting is set.
Fixes #65515
Sending trusted issuers list on Windows is problematic (depends on registry settings), so there were no tests. This PR conditionally enables existing tests on Windows if the relevant registry setting is set.