Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test coverage of FeatureSIMD=0 #66670

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Remove test coverage of FeatureSIMD=0 #66670

merged 4 commits into from
Mar 17, 2022

Conversation

kunalspathak
Copy link
Member

Relevant discussion: #66206 (comment)

Fixes: #66565, #66564, #66206

@ghost ghost assigned kunalspathak Mar 15, 2022
@ghost
Copy link

ghost commented Mar 15, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Relevant discussion: #66206 (comment)

Fixes: #66565, #66564, #66206

Author: kunalspathak
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib , @BruceForstall , @tannergooding

@tannergooding
Copy link
Member

We should also remove the FeatureSIMD entry at

runtime/src/tests/Common/testenvironment.proj

Line 38 in b6fb1d5

COMPlus_FeatureSIMD;

and while not required for this PR, we should have an issue tracking the removal of the COMPlus_FeatureSIMD flag more generally (this is different from the #if defined(FEATURE_SIMD) macro, which needs to stay).

@kunalspathak
Copy link
Member Author

we should have an issue tracking the removal of the COMPlus_FeatureSIMD flag more generally

Updated. Let me know if I missed something.

@kunalspathak
Copy link
Member Author

NativeAOT failures seems related to #66191

@kunalspathak
Copy link
Member Author

ping

@kunalspathak kunalspathak merged commit 05cb7f5 into dotnet:main Mar 17, 2022
This was referenced Mar 17, 2022
Closed
Closed
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@kunalspathak @radekdoulik
Remove test coverage of FeatureSIMD=0 (dotnet#66670)
e01d32b 
* Remove coverge of FeatureSIMD=0

* Remove COMPlus_FeatureSIMD flag

* Remove isSacalarIsa() condition

* Remove the flag from other places of VM
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@kunalspathak kunalspathak

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure JIT\\Regression\\JitBlue\\GitHub_35821\\GitHub_35821\\GitHub_35821.cmd
2 participants
@kunalspathak @tannergooding