-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing CPU from int to double #66743
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetCpuUtilization.cs
Show resolved
Hide resolved
...es/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSourceHelper.Windows.cs
Outdated
Show resolved
Hide resolved
This pull request has been automatically marked |
5e71d76
to
e198c57
Compare
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
...aries/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSourceHelper.Unix.cs
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetCpuUtilization.cs
Outdated
Show resolved
Hide resolved
@stephentoub @ViktorHofer do you know why the analyzer kicked for
In here I see how that lambda (and a few others there) is no longer needed, but I don't see why it wasn't flagged before. I also can't reproduce the warnings when running locally with the same command as one of the failing legs. |
You need to merge from main. This branch is pretty of date with main. New analyzers have been added in the meantime. |
Normally a push should cause a remerge. For example, the last run did a merge on d2264b2 which is from 19 hours ago. |
This PR is changing the methods called from this file. That's why the analyzer kicked in. |
/azp run dotnet-linker-tests,runtime |
Azure Pipelines successfully started running 2 pipeline(s). |
Yes, the github will remerge from main before running the validation, but it won't update the PR. If you want to reproduce the exact same build error locally, you need to do the same remerge locally too. |
Nevermind, I see that the signature needs to be a Func. Now it all makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge from main was not done right.
If you are not sure how to repair it, ping me on Teams and I will walk you through it.
743343e
to
5a2e69f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Failure is known issue #73247 |
Fixes #62525