Support binding to immutable types #43662 #67161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #43662
|
SteveDunn
commented
Mar 25, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Mar 25, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Show resolved
Hide resolved
davidfowl
reviewed
Mar 25, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationBinderTests.cs
Show resolved
Hide resolved
eerhardt
reviewed
Mar 25, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 28, 2022
| @@ -112,6 +112,75 @@ public class DerivedOptionsWithIConfigurationSection : DerivedOptions | |||
| public IConfigurationSection DerivedSection { get; set; } | |||
| } | |||
|
|
|||
| #if NETCOREAPP | |||
There was a problem hiding this comment.
Why is this only on NETCOREAPP?
| @@ -112,6 +112,75 @@ public class DerivedOptionsWithIConfigurationSection : DerivedOptions | |||
| public IConfigurationSection DerivedSection { get; set; } | |||
| } | |||
|
|
|||
| #if NETCOREAPP | |||
| public record RecordTypeOptions(string Color, int Length); | |||
There was a problem hiding this comment.
How about tests for readonly struct and record struct?
| @@ -698,6 +746,37 @@ private static Array BindArray(Array source, IConfiguration config, BinderOption | |||
| options); | |||
| } | |||
|
|
|||
| // todo: steve - we might not need this; currently, these attributes are only applicable to properties and | |||
There was a problem hiding this comment.
What's the plan for addressing this?
I agree that this code doesn't make sense because these attributes can't be on parameters:
…y invoke `ConstructorInfo`
SteveDunn
force-pushed
the
support-binding-to-immutable-types
branch
from
4bf28bc to
15bf080
Compare
SteveDunn
requested review from
jeffhandley,
marek-safar,
lambdageek,
vargaz,
lateralusX,
BrzVlad,
SamMonoRT,
thaystg and
MichalStrehovsky
as code owners
SteveDunn
force-pushed
the
support-binding-to-immutable-types
branch
from
15bf080 to
9d70502
Compare
SteveDunn
force-pushed
the
support-binding-to-immutable-types
branch
from
9d70502 to
9bf910f
Compare
SteveDunn
force-pushed
the
support-binding-to-immutable-types
branch
from
9bf910f to
e32f3b6
Compare
|
I had some git issues and somehow this PR was closed. Is there a way to reopen it? (cc @maryamariyan ) |
|
Apologies @davidfowl @eerhardt - It's been one of those evenings and I completely screwed up my git repo and this PR and somehow accidentally closed this PR. I created a new PR at #67258 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43662
Update
I completely screwed up my git repo and this PR, so it was easier and cleaner to create a new branch and a new PR. This is at #67258.