Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ToTimeoutSeconds.SendPingAsync and fix TimeSpan behavior #67253

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Remove ToTimeoutSeconds.SendPingAsync and fix TimeSpan behavior #67253

merged 3 commits into from
Mar 29, 2022

Commits on Mar 28, 2022

  1. Move CancellationToken throwing logic to the end of Task.Wait 

    To match the default behavior
    @deeprobin
    deeprobin committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0af1d0c View commit details
    Browse the repository at this point in the history

  2. Fix timeout behavior in NetworkStream.Close 

    Use milliseconds instead of seconds
    @deeprobin
    deeprobin committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    46a7ec2 View commit details
    Browse the repository at this point in the history

  3. Remove SendPingAsync overloads

    @deeprobin
    deeprobin committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    bb5a8da View commit details
    Browse the repository at this point in the history