Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for invalid assembly name #67882

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 12, 2022

The error message is always used for invalid assembly name. Delete mention of codebase to avoid confusion.

The error message is always used for invalid assembly name. Delete mention of codebase to avoid confusion.
@ghost ghost assigned jkotas Apr 12, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@danmoseley
Copy link
Member

there's a number of strings in mscorrc.rc and mscorurt.rc that relate to the GAC or AppDomains. Yet (per my recent change) are at least referenced in the code. Should we clean those up too?

@jkotas
Copy link
Member Author

jkotas commented Apr 12, 2022

there's a number of strings in mscorrc.rc and mscorurt.rc that relate to the GAC or AppDomains.

The HRESULTs associated with these error messages are never going to be produced by CoreCLR.

The only reason for these error messages to exist is that the interop APIs recognize them when mapping HRESULTs to exceptions and error messages. For example, this is going to print error message that talks about GAC:

Console.WriteLine(System.Runtime.InteropServices.Marshal.GetExceptionForHR(unchecked((int)0x80131050), new IntPtr(-1)));

It would be an observable behavior change to stop recognizing these HRESULTs. I think it would be ok to clean this up if you are interested doing it.

@jkotas jkotas merged commit 6ea5fa5 into dotnet:main Apr 12, 2022
@jkotas jkotas deleted the invalid-name branch April 12, 2022 16:38
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants