Delete legacy HRESULTs and error messages #68252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of HRESULTs and error messages related to GAC, CAS and other concepts remove in .NET Core existed just to providing mapping in Marshal.GetExceptionForHR API. They were otherwise unused. Deleting these HRESULTs is observable behavior change of Marshal.GetExceptionForHR. It should be acceptable change given that these HRESULTs are never returned by the runtime and very unlikely to be used by user code.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
AaronRobinsonMSFT
approved these changes
Apr 20, 2022
stephentoub
approved these changes
Apr 20, 2022
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
Number of HRESULTs and error messages related to GAC, CAS and other concepts remove in .NET Core existed just to provide mapping in Marshal.GetExceptionForHR API. They were otherwise unused. Deleting these HRESULTs is observable behavior change in Marshal.GetExceptionForHR. It should be acceptable change given that these HRESULTs are never returned by the runtime and very unlikely to be used by user code.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of HRESULTs and error messages related to GAC, CAS and other concepts remove in .NET Core
existed just to providing mapping in Marshal.GetExceptionForHR API. They were otherwise unused.
Deleting these HRESULTs is observable behavior change of Marshal.GetExceptionForHR. It should be
acceptable change given that these HRESULTs are never returned by the runtime and very unlikely to
be used by user code.