Delete AssemblySpec::m_wszCodeBase #68186
Conversation
This was only used for assembly loading using hosting APIs that can be short-circuited to load directly without going through AssemblySpec
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsThis was only used for assembly loading using hosting APIs that can be short-circuited to load directly without going through AssemblySpec
|
| if (assemblyPath.MatchCaseInsensitive(pos, s_httpURLPrefix)) | ||
| { | ||
| // HTTP downloads are unsupported | ||
| hr = FUSION_E_CODE_DOWNLOAD_DISABLED; |
There was a problem hiding this comment.
I think we can remove the FUSION_E_CODE_DOWNLOAD_DISABLED error code and message too.
There was a problem hiding this comment.
This and other similar no-longer-used HRESULTs are coupled with the managed exceptions today. It would be nice to clean them up, but I am not going to do in this PR.
|
I didn't look into the details yet - but does this mean we can't really fix #59669 even if we wanted to? |
|
I think the only thing that a fix for #59669 would need that this PR deletes is the field so that code base can be propagated somehow. The vast majority of this cleanup is the convoluted handling we have for when is/isn't codebase set, which we shouldn't need just to be able to propagate the value to extension points. I actually think this PR would make any fix for that issue more straight-forward, since it becomes an issue of propagating a property rather than propagating a property and trying to fit it into some existing mechanism that has different logic/behaviour for binding. |
|
The codebase is missing from multiple layers between |
1 similar comment
|
The codebase is missing from multiple layers between |
* Delete AssemblySpec::m_wszCodeBase This was only used for assembly loading using hosting APIs that can be short-circuited to load directly without going through AssemblySpec * Delete unnecessary ownedFlags argument
ghost
locked as resolved and limited conversation to collaborators
This was only used for assembly loading using hosting APIs that can be short-circuited to load directly without going through AssemblySpec