Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle mis-sized structs in ARM/64 PUTARG_STK codegen #69905

Merged
merged 3 commits into from
May 28, 2022
Merged

Handle mis-sized structs in ARM/64 PUTARG_STK codegen #69905

merged 3 commits into from
May 28, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 27, 2022 •
edited
Loading

Utilize a strategy similar to what x64/x86 codegen does: load progressively smaller types.

No diffs as expected.

Closes #60705.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 27, 2022
@ghost
Copy link

ghost commented May 27, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Let's see if this fixed the CI issue.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion
Handle mis-sized structs for PUTARG_STK on ARM/64
aaf61c3 
We will now generate a series of small loads as necessary
to handle "remainderSize"s of 3, 5, 6 and 7.
@SingleAccretion
Add tests
78164a7
@SingleAccretion
Re-enable tests for 60705
5d6a2bc
@SingleAccretion SingleAccretion force-pushed the PutArgStk-ArmArch-Odd-Sized-Structs branch from c5c96bb to 5d6a2bc Compare May 28, 2022 12:44
@SingleAccretion SingleAccretion marked this pull request as ready for review May 28, 2022 15:36
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

jakobbotsch
jakobbotsch approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jakobbotsch jakobbotsch merged commit 120e2f5 into dotnet:main May 28, 2022
@SingleAccretion SingleAccretion deleted the PutArgStk-ArmArch-Odd-Sized-Structs branch May 28, 2022 16:37
@BruceForstall BruceForstall mentioned this pull request May 31, 2022
Merged
@jakobbotsch jakobbotsch mentioned this pull request May 31, 2022
Closed
@SingleAccretion SingleAccretion mentioned this pull request Jun 5, 2022
Merged
@SingleAccretion SingleAccretion mentioned this pull request Jun 27, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JIT assert on arm32 when running DllImportGenerator unit tests: remainingSize == 4
2 participants
@SingleAccretion @jakobbotsch