Enable TYP_STRUCT LCL_VAR/LCL_FLD call args on LA
#71327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFor now, lower the local nodes into
|
Closed
|
@dotnet/jit-contrib, @shushanhf |
SingleAccretion
force-pushed
the
Struct-LclFld-Args-LA-Upstream
branch
from
8421d92
to
2288914
Compare
jakobbotsch
approved these changes
Jul 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, lower the local nodes into
OBJs, as full codegen support would require changes I deem too extensive for the level of validation that we have for LA currently.For context, the changes to port to LA to would be:
#69905
#70256
#69905
#70861
I plan to do this eventually; as part of the final push to delete
ADDR.