Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rely on GT_ADDR in gtFoldBoxNullable #69961

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Do not rely on GT_ADDR in gtFoldBoxNullable #69961

merged 1 commit into from
Jun 6, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 29, 2022 •
edited
Loading

Instead, get the class handle from the helper arg node.

Diffs.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 29, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 29, 2022
@ghost
Copy link

ghost commented May 29, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead, get the class handle from the helper arg node.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion SingleAccretion force-pushed the Box-Nullable-Cmp-Null branch from 2a84172 to 42d9bf0 Compare May 29, 2022 14:18
@SingleAccretion SingleAccretion mentioned this pull request May 29, 2022
Merged
@SingleAccretion SingleAccretion marked this pull request as ready for review May 29, 2022 17:17
@SingleAccretion
Copy link
Contributor Author

CI failures:

  1. Libraries Build windows x86 Debug - ILLinker NRE on Windows #69536.
  2. Libraries Test Run checked coreclr Linux arm64 Debug - likely ARM32/ARM64 gcstress-extra failures #69657 (S.T.RegEx.Tests are failing everywhere right now with memory corruption symptoms).
  3. coreclr Pri0 Runtime Tests Run windows arm64 checked - Windows ARM64 + empty log.

@dotnet/jit-contrib

@JulieLeeMSFT JulieLeeMSFT requested a review from jakobbotsch June 2, 2022 19:05
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jun 2, 2022
@SingleAccretion
Generalize the "BOX(nullable) cmp null" opt
ad8d99f 
We can obtain the "Nullable<T>" class handle from the helper's arg.
@SingleAccretion SingleAccretion force-pushed the Box-Nullable-Cmp-Null branch from 42d9bf0 to ad8d99f Compare June 4, 2022 18:15
@jakobbotsch jakobbotsch merged commit c61db46 into dotnet:main Jun 6, 2022
@SingleAccretion SingleAccretion deleted the Box-Nullable-Cmp-Null branch June 6, 2022 10:52
@ghost ghost locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@jakobbotsch jakobbotsch

@SingleAccretion SingleAccretion

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SingleAccretion @jakobbotsch @JulieLeeMSFT