-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILLinker NRE on Windows #69536
Comments
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue Details
|
cc @eerhardt |
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Details
|
@radical - has this happened on any other build than your PR? Does it repro in |
No, I have seen it only this one time. |
Are you sure the failure isn't caused by your changes? Can you repro it yourself with your changes? |
It passed on the second attempt by azdo for the same commit of my branch. My PR has very few non-wasm specific changes, and this is not for a wasm run. |
Hmm, that's odd for a NRE in the linker to be non-deterministic. @agocke @vitek-karas @sbomer - thoughts? |
Occurred in #69619 on "Libraries Build windows allConfigurations x64 Debug"
|
If it's indeed non-deterministic, it's probably an issue in the .NET runtime running the tool. We started to see various mystery bugs in managed tools that run as part of the build ever since switching to the .NET 7 SDK/runtime. Here's a similar NRE in crossgen2: #69454. The theory is that these are all related, possibly fixed with #68443 and will be fixed once we update to Preview 5 (#69593 (comment)). |
Another NRE, though it doesn't look the same. But I'll leave it up to others to decide whether to split it off into a new issue or not. This is on p5 rolling build:
The linker was updated recently with #69644 . |
Hmm, that method body hasn't been modified recently. It also doesn't look like it happened in the next build. Seems unlikely to be a linker issue. |
Another failure on https://dev.azure.com/dnceng/public/_build/results?buildId=1797953&view=logs&j=55f4943c-f76d-585b-7250-deab324f0a54&t=18a666a9-d033-504f-063f-baac7386b04a
|
Another NRE, on a rolling build:
|
Do we have a working theory for what is causing these? |
The other recent linker exceptions - dotnet/linker#2789 , and #70031 . |
Or a way to get a trace dump so someone can investigate? Has anyone been able to repro this outside of CI? |
As far as I know we haven't seen this outside of CI - and it's not very common in CI either (less than once a day). The current theory is that it's related to #68443. Problem is that crossgen2 and linker both run on the runtime which comes with the SDK and not with the runtime which is live built. So even though the possible cause of this has been fixed for a while, it can still show up for the tools. As for the crash dump - we have discussed this a little, but I'll continue that discussion today. Right now I don't think we have a way to get a crash dump of these failures from the CI. And even locally it will be hard - it's an exception which is handled by the process, so one would have to run it under debugger to catch this. |
So to clarify, it looks like we're waiting on #70117 which @ViktorHofer would prefer not to land until p5 is officially released? How much confidence do we have that the fixes in p5 will resolve the issues? |
Another one on #20220603.2
|
This doesnt appear to be the potential GC issue. @radical, Is there a dump available to look at? |
I don't see one. Maybe @vitek-karas has an answer (ref: #69536 (comment)). |
AFAIK this is only happening in builds, and we don't collect crash dumps on build machines. However, we should change the linker to stop swallowing exceptions, dotnet/linker#2824 |
If this was a GC hole, as we suspected, then Preview 5 is merged and this shouldn't happen anymore. Closing until we see new faliures. |
Build:
The text was updated successfully, but these errors were encountered: