Fix --fulllog in ILC/crossgen2
#69996
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue reported in dotnet#66716 (comment). We create a hashset for the purpose of avoiding this problem, check it, but never add to it.
ghost
assigned 
jakobbotsch
reviewed
May 31, 2022
Comment on lines
160
to
163
| if (!combinedNodesReported.Contains(combinedNode)) | ||
| { | ||
| logNodeVisitor.VisitCombinedNode(combinedNode); | ||
| combinedNodesReported.Add(combinedNode); |
There was a problem hiding this comment.
Suggested change
| if (!combinedNodesReported.Contains(combinedNode)) | |
| { | |
| logNodeVisitor.VisitCombinedNode(combinedNode); | |
| combinedNodesReported.Add(combinedNode); | |
| if (combinedNodesReported.Add(combinedNode)) | |
| { | |
| logNodeVisitor.VisitCombinedNode(combinedNode); |
There was a problem hiding this comment.
(If reordering the check and call is ok.)
jakobbotsch
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported in #66716 (comment).
We create a hashset for the purpose of avoiding this problem, check it, but never add to it.
Cc @dotnet/ilc-contrib @dotnet/crossgen-contrib