Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Work around for UriFormatException caused by \\?\ prefix in the path #71452

Merged
merged 5 commits into from
Aug 11, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 29, 2022

Backport of #71082 and #58627 to release/6.0

Description

Long paths prefixed with \\?\ is throwing in Uri ctor which causing UriFormatException in ConfigurationManager code that creates Uri with a long name which causes WinForms designer crush.

Customer Impact

According to @RussKie : In .NET Framework the Windows Forms designer is run in the VS process. To facilitate the .NET support the designer was moved out-of-proc, and the server process is started with '\\?\' path. We'd want the fix to be serviced in to .NET 6, as this bug is blocking the adoption and there is no workaround for them unless it is fixed in runtime

Testing

This PR includes 2 PR commits

Risk

Very low - the fixes here has no functional change/impact, literally workarounds that avoid using Uri ctor that throws for \\?\ prefix within System.Configuration.ConfigurationManager project

Fixes #70318

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Jun 29, 2022

Tagging subscribers to this area: @dotnet/area-system-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #71082 to release/6.0

/cc @buyaa-n

Customer Impact

Testing

Risk

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Configuration

Milestone: -

@carlossanlop
Copy link
Member

@buyaa-n the servicing consider label is missing in this PR, so it never went through Tactics. Can you please add it and send an email to the tactics alias as well?

@buyaa-n
Copy link
Contributor

buyaa-n commented Jul 13, 2022

Yes, did not add that and prepared for template yet because it is not ready, waiting for the WinForms testing result from @RussKie but he seems out

This fix is literally workaround and has no unit test, I have manually tested with the project attached to the issue, but for servicing its better to make sure it fixes the WinForms issue completely as they are requesting for servicing

@RussKie
Copy link
Member

RussKie commented Jul 25, 2022

Thank you!

/cc: @merriemcgaw @Shyam-Gupta

@buyaa-n
Copy link
Contributor

buyaa-n commented Jul 26, 2022

The failures are unrelated. seems mostly infra related filed an issue.

This is approved by email, so changing the label with servicing approved

@buyaa-n buyaa-n added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 26, 2022
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infrastructure changes LGTM

@buyaa-n buyaa-n modified the milestones: 6.0.x, 6.0.9 Jul 27, 2022
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tactics approved.
Correct milestone applied.
CI failures are unrelated.
Necessary OOB package authoring changes included.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 6b19fb5 into release/6.0 Aug 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2022
@jkotas jkotas deleted the backport/pr-71082-to-release/6.0 branch October 1, 2022 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants