-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Work around for UriFormatException caused by \\?\ prefix in the path #71452
Conversation
Tagging subscribers to this area: @dotnet/area-system-configuration Issue DetailsBackport of #71082 to release/6.0 /cc @buyaa-n Customer ImpactTestingRiskIMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
@buyaa-n the |
Yes, did not add that and prepared for template yet because it is not ready, waiting for the WinForms testing result from @RussKie but he seems out This fix is literally workaround and has no unit test, I have manually tested with the project attached to the issue, but for servicing its better to make sure it fixes the WinForms issue completely as they are requesting for servicing |
Thank you! /cc: @merriemcgaw @Shyam-Gupta |
The failures are unrelated. seems mostly infra related filed an issue. This is approved by email, so changing the label with servicing approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infrastructure changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tactics approved.
Correct milestone applied.
CI failures are unrelated.
Necessary OOB package authoring changes included.
Ready to merge.
Backport of #71082 and #58627 to release/6.0
Description
Long paths prefixed with
\\?\
is throwing in Uri ctor which causingUriFormatException
in ConfigurationManager code that creates Uri with a long name which causes WinForms designer crush.Customer Impact
According to @RussKie :
In .NET Framework the Windows Forms designer is run in the VS process. To facilitate the .NET support the designer was moved out-of-proc, and the server process is started with '\\?\' path. We'd want the fix to be serviced in to .NET 6, as this bug is blocking the adoption
and there is no workaround for them unless it is fixed in runtimeTesting
This PR includes 2 PR commits
Risk
Very low - the fixes here has no functional change/impact, literally workarounds that avoid using Uri ctor that throws for
\\?\
prefix within System.Configuration.ConfigurationManager projectFixes #70318
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.