Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more libraries tests #73104

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jul 30, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: MichalStrehovsky
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

@jkotas does the fix for RuntimeInformation.RuntimeIdentifier look reasonable? We could compute the Linux distro name at runtime, but I would want it to be done lazily and that's currently not compatible with it being stored as an AppContext value. Could just file an issue on that.

@jkotas
Copy link
Member

jkotas commented Jul 31, 2022

does the fix for RuntimeInformation.RuntimeIdentifier look reasonable?

Yes, it looks reasonable. We are working towards getting rid of the distro-specific RIDs: dotnet/designs#260

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants