Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-staging: Enable failed tests on stable jobs to fail the job #73400

Merged
merged 4 commits into from
Aug 8, 2022

Commits on Aug 5, 2022

  1. xplat-setup.yml: Add support for setting shouldContinueOnError to

    .. `false`.
    
    Currently, xplat-setup.yml passes on `shouldContinueOnError` to the
    template with `true` if the parameter was `true`, else it sets the value
    based on whether this is for runtime-staging, on a PR.
    
    Which essentially means that runtime-staging defaults to
    `shouldContinueOnError: true` for PRs, or we can set it explcitly to
    `true` which would affect the rolling builds.
    
    But this does not allow making a runtime-staging job *fail* when *tests
    fail*. To support that this change adds a check for a special value
    `forceFalse`, which causes the param to explicitly set to `false`. Thus
    allowing `runtime-staging` builds to be marked as such.
    radical committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    522a01f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    357f99d View commit details
    Browse the repository at this point in the history
  3. fix comment

    radical committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    ebf1674 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Configuration menu
    Copy the full SHA
    c957f74 View commit details
    Browse the repository at this point in the history