runtime-staging
: Enable failed tests on stable jobs to fail the job
#73400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xplat-setup.yml: Add support for setting shouldContinueOnError to
..
false
.Currently, xplat-setup.yml passes on
shouldContinueOnError
to thetemplate with
true
if the parameter wastrue
, else it sets the valuebased on whether this is for runtime-staging, on a PR.
Which essentially means that runtime-staging defaults to
shouldContinueOnError: true
for PRs, or we can set it explcitly totrue
which would affect the rolling builds.But this does not allow making a runtime-staging job fail when tests
fail. To support that this change adds a check for a special value
forceFalse
(thanks to @akoeplinger for the suggestion), which causesthe param to explicitly set to
false
. Thus allowingruntime-staging
builds to be marked as such.
These jobs will now fail when their tests fail:
This will prevent errors getting missed, and merged because
runtime-staging
wasn't looked atAlso, add more paths to trigger tests on CI
Related: #73166