Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-staging: Enable failed tests on stable jobs to fail the job #73400

Merged
merged 4 commits into from
Aug 8, 2022
Merged

runtime-staging: Enable failed tests on stable jobs to fail the job #73400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
522a01f
xplat-setup.yml: Add support for setting `shouldContinueOnError` to
radical Aug 4, 2022
357f99d
[wasm] Add more paths to trigger running tests on CI
radical Aug 4, 2022
ebf1674
fix comment
radical Aug 5, 2022
c957f74
Merge branch 'dotnet:main' into ci-fixes
radical Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions eng/pipelines/common/evaluate-default-paths.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ jobs:
- src/tests/BuildWasmApps/Directory.Build*
- src/tests/BuildWasmApps/Wasm.Build.Tests/*
- src/mono/wasm/build/*
- src/mono/wasm/host/*
- src/mono/wasm/runtime/*
- src/mono/wasm/templates/*
- src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/*
Expand All @@ -135,7 +136,17 @@ jobs:
- subset: allwasm
include:
- eng/Version.Details.xml
- src/mono/*.proj
- src/mono/Directory.Build*
- src/mono/CMakeLists.txt
- src/mono/System.Private.CoreLib/*
- src/mono/mono/*
- src/mono/wasm/emscripten-version.txt
- src/mono/wasm/build/*
- src/mono/wasm/data/aot-tests/*
- src/mono/wasm/runtime/*
- src/mono/wasm/test-main.js
- src/mono/wasm/wasm.proj

- ${{ if ne(parameters.extraSubsets, '') }}:
- ${{ parameters.extraSubsets }}
2 changes: 2 additions & 0 deletions eng/pipelines/common/templates/wasm-build-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ parameters:
alwaysRun: false
isExtraPlatformsBuild: false
platforms: []
shouldContinueOnError: false

jobs:

Expand All @@ -15,6 +16,7 @@ jobs:
buildConfig: Release
runtimeFlavor: mono
platforms: ${{ parameters.platforms }}
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
variables:
# map dependencies variables to local variables
- name: wasmbuildtestsContainsChange
Expand Down
4 changes: 2 additions & 2 deletions eng/pipelines/common/xplat-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ parameters:
platform: ''
targetRid: ''
jobParameters: {}
shouldContinueOnError: false
shouldContinueOnError: false # set `shouldContinueOnError: forceFalse` to not use the defaults, and set specifically to `false`
variables: []

jobs:
- template: ${{ coalesce(parameters.helixQueuesTemplate, parameters.jobTemplate) }}
parameters:
shouldContinueOnError: ${{ or(eq(parameters.shouldContinueOnError, true), and(endsWith(variables['Build.DefinitionName'], 'staging'), eq(variables['Build.Reason'], 'PullRequest'))) }}
shouldContinueOnError: ${{ or(eq(parameters.shouldContinueOnError, true), and(ne(parameters.shouldContinueOnError, 'forceFalse'), endsWith(variables['Build.DefinitionName'], 'staging'), eq(variables['Build.Reason'], 'PullRequest'))) }}

# keep in sync with /eng/pipelines/common/variables.yml
dependOnEvaluatePaths: ${{ and(eq(variables['Build.Reason'], 'PullRequest'), in(variables['Build.DefinitionName'], 'runtime', 'runtime-staging', 'runtime-community', 'runtime-extra-platforms')) }}
Expand Down
7 changes: 5 additions & 2 deletions eng/pipelines/runtime-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ jobs:
- template: /eng/pipelines/common/evaluate-default-paths.yml

#
# WebAssembly legs - run windows builds. Also, debugger tests which are currently
# unstable
# WebAssembly legs - library tests, Wasm.Build.Tests, and debugger tests
#
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
parameters:
platforms:
- Browser_wasm_win
shouldContinueOnError: forceFalse
alwaysRun: ${{ variables.isRollingBuild }}
scenarios:
- WasmTestOnBrowser
Expand All @@ -78,19 +78,22 @@ jobs:
nameSuffix: _AOT
runSmokeOnlyArg: $(_runSmokeTestsOnlyArg)
runAOT: true
shouldContinueOnError: forceFalse
alwaysRun: ${{ variables.isRollingBuild }}

- template: /eng/pipelines/common/templates/wasm-build-tests.yml
parameters:
platforms:
- Browser_wasm_win
shouldContinueOnError: forceFalse
alwaysRun: ${{ variables.isRollingBuild }}

- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
parameters:
platforms:
- Browser_wasm
- Browser_wasm_win
shouldContinueOnError: forceFalse
alwaysRun: ${{ variables.isRollingBuild }}

- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
Expand Down