Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-determinism from R2R field access #73663

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Remove non-determinism from R2R field access #73663

merged 2 commits into from
Aug 11, 2022

Conversation

davidwrighton
Copy link
Member

  • Remove all trace of storing off the field token in a compiler non-deterministic manner
  • Notably, remove the _fieldToRefTokens field from ModuleTokenResolver, and remove the ability of that class to resolve tokens for fields
  • Add a new concept called FieldWithToken modeled after MethodWithToken
  • Plumb through the various dependency analysis structures as needed

Fixes #73403

@davidwrighton
Remove non-determinism from R2R field access
d7e077c 
- Remove all trace of storing off the field token in a compiler non-deterministic manner
 - Notably, remove the _fieldToRefTokens field from ModuleTokenResolver, and remove the ability of that class to resolve tokens for fields
- Add a new concept called FieldWithToken modeled after MethodWithToken
- Plumb through the various dependency analysis structures as needed

Fixes dotnet#73403
@davidwrighton davidwrighton requested a review from trylek August 9, 2022 23:19
@ghost ghost assigned davidwrighton Aug 9, 2022
trylek
trylek approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@runfoapp runfoapp bot mentioned this pull request Aug 10, 2022
Closed
@davidwrighton davidwrighton merged commit 0559d4a into dotnet:main Aug 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2022
@davidwrighton davidwrighton deleted the fix_field_nondeterminism branch April 13, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@davidwrighton davidwrighton

Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crossgen2 determinism issue found in Roslyn
2 participants
@davidwrighton @trylek