Fix component model aot test #73734
Merged
Fix component model aot test #73734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/tests/BindableAttributeTests.cs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,15 @@ | |||
| <Directives> | |||
| <Application> | |||
| <Assembly Name="mscorlib" /> | |||
There was a problem hiding this comment.
I'm a little bit worried that such broadly applied RD.XML will hide product issues. But also I don't know how much of TypeConverter actually is compatible with trimming and whether it even makes sense to guard trim safety.
Just thought to write down what I think.
There was a problem hiding this comment.
I disabled 7 test scenarios, all in XTypeDescriptionProviderTests, to get rid of the rd.xml dependency.
LakshanF
force-pushed
the
FixComponentModelAotTest
branch
from
cea1e6f
to
72ec834
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
approved these changes
Aug 12, 2022
src/libraries/System.ComponentModel.TypeConverter/tests/BindableAttributeTests.cs
Outdated
Show resolved
Hide resolved
…leAttributeTests.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some requires types to an rd.xml files, disabled some Jit tests and #73605 fixed some additional tests