Warn if runtimeconfig.template.json is used with PublishAot #73996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Aug 16, 2022
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Aug 16, 2022
…e.Publish.targets Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Relevant pipelines are green. |
|
@MichalStrehovsky @jkotas is it ok to have this change in 7.0? Since we had to delay the snap for a full day, this commit will end up getting included in the RC1 snap. Letting you know in case you want to do something about it. |
Yes, all my PRs from yesterday were taking advantage of the moved deadline. I've fixed several papercut-level issues that I'm happy to see fixed for 7.0. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72310.
Cc @dotnet/ilc-contrib