Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'release/7.0-rc1' => 'release/7.0' #74045

Commits on Aug 17, 2022

  1. Use buffer.Length as the source of truth for ReadDirectoryChanges (do…

    …tnet#74023)
    
    Co-authored-by: David Cantú <dacantu@microsoft.com>
    github-actions[bot] and jozkee authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    12d9354 View commit details
    Browse the repository at this point in the history
  2. [release/7.0-rc1] [wasm][debugger] Hide members from classes that don…

    …'t have debug information (dotnet#74029)
    
    * adding fields that are from non-user-code as private
    
    * Do not show members from types that doesn't have debug information if JMC is enabled.
    
    * Addressing @radical comments.
    
    * Apply suggestions from code review
    
    Co-authored-by: Ankit Jain <radical@gmail.com>
    
    * Adding more tests.
    
    Co-authored-by: Thays Grazia <thaystg@gmail.com>
    Co-authored-by: Ankit Jain <radical@gmail.com>
    3 people authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    6157b3d View commit details
    Browse the repository at this point in the history
  3. Product dependencies in Versions.props must be on the latest patch ve…

    …rsion for libraries dependencies (dotnet#74024)
    
    Co-authored-by: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
    github-actions[bot] and carlossanlop authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    3d7d087 View commit details
    Browse the repository at this point in the history
  4. Don't set PublishAot in SDK by default (dotnet#74048)

    Co-authored-by: Sven Boemer <sbomer@gmail.com>
    github-actions[bot] and sbomer authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    0f2546f View commit details
    Browse the repository at this point in the history
  5. Add missing .npmrc (dotnet#74039)

    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    github-actions[bot] and lewing authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    d8866dc View commit details
    Browse the repository at this point in the history
  6. [release/7.0-rc1] [mono] Implement missing functionality for cctor in…

    …vocation (dotnet#74043)
    
    * [mono] Implement missing functionality for cctor invocation
    
    * [mono] Re-enable test
    
    Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
    github-actions[bot] and BrzVlad authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    8baff7d View commit details
    Browse the repository at this point in the history
  7. [release/7.0-rc1] Optimized string.Replace(char, char) (dotnet#74047)

    * Optimized string.Replace(char, char) vector code path
    
    * Optimized code pathes even further
    
    * Do vectorized operation at the end of the string only once
    
    When the remaining length is a multiple of the vector size, then the remainder is processed twice. This is redundant, and not needed.
    This commit changes that, so that the remainder is processed only once when the remaining elements match.
    
    * Don't use trick for collapsed epilogs
    
    Cf. dotnet#67049 (comment)
    
    * Handle remainder vectorized even if remainingLength <= Vector<ushort>.Count and added tests for this
    
    * Introduce (internal) Vector.LoadUnsafe and Vector.StoreUnsafe and use it in string.Replace(char, char)
    
    * Avoid Unsafe.As<char, ushort> reinterpret casts by introducing string.GetRawStringDataAsUshort() internal method
    
    * Fixed copy/paste error (from local dev to repo)
    
    * PR Feedback
    
    * Fixed bug and added tests for this
    
    * Make condition about lengthToExamine clearer as suggested
    
    Co-authored-by: Günther Foidl <gue@korporal.at>
    github-actions[bot] and gfoidl authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    ceef11f View commit details
    Browse the repository at this point in the history
  8. [release/7.0-rc1] Workload changes - account for SDK bands and use ar…

    …chives (dotnet#74054)
    
    * Update arcade to 7.0.0-beta.22416.1
    * Port workload changes from release/6.0
    * workloads: Add multithread, and perftrace runtime packs for wasm workload
    * Mono.ToolChain.Manifest short name
    * Change order of shortnames
    
    Co-authored-by: Juan Sebastian Hoyos Ayala <juan.hoyos@microsoft.com>
    Co-authored-by: Jacques Eloff <joeloff@users.noreply.github.com>
    Co-authored-by: Ankit Jain <radical@gmail.com>
    4 people authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    02789c3 View commit details
    Browse the repository at this point in the history
  9. Vectorize {Last}IndexOf{Any}{Except} without code duplication (dotnet…

    …#73768) (dotnet#74086)
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    adamsitnik and jkotas authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    cad2af2 View commit details
    Browse the repository at this point in the history
  10. [release/7.0-rc1] perf pipeline: Switch to node 14.x (dotnet#74089)

    * perf pipeline: Switch to node 14.x
    
    - Switch to node 14.x instead of 18.x, because the latter doesn't seem
    to be compatible with ubuntu 18.x:
    `node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)`
    
    - Also, remove the existing `nodejs` package before installing a new
    one, because these machines are shared, and would get affected by
    installations performed by other runs.
    
    * perf pipeline: install wasm pre-reqs only on wasm jobs
    
    * perf pipeline: correctly return exit code, so helix can pick that up and set _commandExitCode
    
    * Set a default value for non-wasm cases
    
    * Change the prereqs condition so a failure needs to be explicitly marked
    
    This allows cases which don't care about this, to continue working,
    because they won't set `$PERF_PREREQS_INSTALL_FAILED`, and default to
    continuing with the job.
    
    * Use --user with pip install
    
    * Update eng/testing/performance/microbenchmarks.proj
    
    Co-authored-by: Ankit Jain <radical@gmail.com>
    github-actions[bot] and radical authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    d4b85ca View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Don't fail the test when the file is in use, fixes dotnet#73925 (dotn…

    …et#74094)
    
    Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    github-actions[bot] and adamsitnik authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    dc98f58 View commit details
    Browse the repository at this point in the history
  2. [release/7.0-rc1] Fix auto layout algorithm to compute structure alig…

    …nment correctly (dotnet#74091)
    
    * New test
    
    * Fix auto layout algorithm to compute structure alignment correctly - In particular: 1. The alignment requirement imposed by of a non-primitive, non-enum valuetype field is the alignment of that field 2. The alignment requirement imposed by a primitive is the pointer size of the target platform, unless running on Arm32, in which case if the primitive or enum is 8 bytes in size, the alignment requirement is 8.
    
    - The previous implementation produced an alignment of pointer size, unless running on Arm32 and one of the fields had an alignment requirement of 8 (in which case the alignment requirement computed for the structure would be 8)
    
    In addition, add a test which verifies that the instance field layout test types are actually producing R2R compatible results at runtime.
     - This test shows that we have some issues around explicit layout, so I was forced to disable that portion of the test for now.
    
    Fixes dotnet#65281
    
    * Re-enable disabled test
    
    * Remove file that shouldn't be added as part of the new test
    
    * Make a few test types public to silence unassigned field errors
    
    * Update comments and add more testing
    
    Co-authored-by: David Wrighton <davidwr@microsoft.com>
    Co-authored-by: Tomas Rylek <trylek@microsoft.com>
    3 people authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    a969995 View commit details
    Browse the repository at this point in the history
  3. [release/7.0-rc1] Add Arm64 PGO/IBC to Windows and Linux builds (dotn…

    …et#74098)
    
    * Add Arm64 PGO/IBC to Windows and Linux builds
    
    * WIP
    
    * Update opt data package version
    
    Co-authored-by: Drew Scoggins <anscoggi@microsoft.com>
    github-actions[bot] and DrewScoggins authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    7ea346d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7ab10ff View commit details
    Browse the repository at this point in the history
  5. [release/7.0-rc1] Fix nullable annotations on generic math interfaces (

    …dotnet#74116)
    
    * Fix nullable annotations on generic math interfaces
    
    - All `where TSelf : ...` constraints become `where TSelf : ...?`.  Without this, trying to define a type like `Matrix<T> where T : INumber<T>?` in order to support nullable T types warns because `INumber<T>` constrains its `T` (`TSelf`) to be non-nullable.
    - All `where TOther : ...` constraints are changed to be oblivious. They can't be correctly annotated as there's no way to express the nullability relationship with the nullability of TSelf.
    - Use `[MaybeNullWhen(false)] out T` instead of `[NotNullWhen(true)] out T?`, as we do with other generics, since if the instantiation of `T` is nullable, we can't guarantee `NotNullWhen(true)`.
    - Make `IEqualityOperators` `==` and `!=` accept `TSelf?`. This keeps it consistent with `IEquatable<T>.Equals(T?)`, `IEqualityComparer<in T>.Equals(T?, T?)`, `IEqualityComparer.Equals(object?, object?)`, `IStructuralEquatable.Equals(object?, IEqualityComparer)`, and `object.Equals(object?)` which all allow null even if generic and the generic is non-null. It in turn enables checks like `T.Zero == default` without nullability warnings.
    
    * Address PR feedback
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    github-actions[bot] and stephentoub authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    68aebc1 View commit details
    Browse the repository at this point in the history
  6. [release/7.0-rc1] Move runtimeconfig.template.json stuff to csproj (d…

    …otnet#74144)
    
    * Move runtimeconfig.template.json stuff to csproj
    
    NativeAOT ignores this and emits a warning. This fails the test build.
    
    * It wasn't just one
    
    * Update src/libraries/System.Resources.ResourceManager/tests/System.Resources.ResourceManager.Tests.csproj
    
    Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    3 people authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    08fdcb7 View commit details
    Browse the repository at this point in the history
  7. [release/7.0-rc1] [NativeAOT] Add method parameter names to stack tra…

    …ce if available (dotnet#74145)
    
    * Emit parameter names
    
    Fixes dotnet#73051
    
    * Address PR feedback
    
    * Rename things
    
    * Apply suggestions from code review
    
    Co-authored-by: jasperd <jasper-d@users.noreply.github.com>
    Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    3 people authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    0ec29b6 View commit details
    Browse the repository at this point in the history