Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] Omit the JS sync context if threads are not enabled #74236

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #74167 to release/7.0-rc1

/cc @maraf @kg

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@maraf maraf added the arch-wasm WebAssembly architecture label Aug 19, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74167 to release/7.0-rc1

/cc @maraf @kg

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: -

@kg
Copy link
Contributor

kg commented Aug 19, 2022

The failure log for Linux x64 Debug doesn't actually show any test failures:

  Finished:    System.Net.Http.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Http.Functional.Tests  Total: 3776, Errors: 0, Failed: 0, Skipped: 14, Time: 120.634s

@carlossanlop
Copy link
Member

@marek-safar @lewing need an approval before I merge.

@lewing
Copy link
Member

lewing commented Aug 22, 2022

This fixes a size regression.

This will break blazor's very fragile manifest checks in the sdk but they already need to be updated (see dotnet/sdk#27307)

cc @TanayParikh

@carlossanlop
Copy link
Member

This was approved, signed-off and the CI failure is unrelated. Ready to merge.

@carlossanlop carlossanlop merged commit de3cd20 into release/7.0-rc1 Aug 22, 2022
@carlossanlop carlossanlop deleted the backport/pr-74167-to-release/7.0-rc1 branch August 22, 2022 15:31
@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants