-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.1xx-rc1] Update dependencies from dotnet/runtime #27365
[release/7.0.1xx-rc1] Update dependencies from dotnet/runtime #27365
Conversation
…0822.23 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22421.12 -> To Version 7.0.0-rc.1.22422.23
@eerhardt looks like the infernal publish baselines need an update here also |
@mkArtakMSFT if we're going to keep these tests enabled we need someone to own updating them. The manifest changes here are from dotnet/runtime#74236 |
In case anyone needs to update the baselines in the future, here are the steps I did:
|
How often have these baseline tests found an issue, historically? |
@danmoseley we had quite a good number of issues in .NET 3.1 and 5.0 related to the MSBuild pipeline for Blazor apps, that's why we introduced the baselines. It's a trade-off between catching regressions and having to manually update the baselines when they change. At the time, we did not expect this to cause much friction, but I understand we might have seen more changes than we originally expected. Normally someone on the ASP.NET Team is watching for these PRs and will ping the relevant people, but you can always ping @mkArtakMSFT, @TanayParikh or me and we'll deal with it as soon as possible. I'll figure out if we can relax some of the ways in which we check these baselines to be more tolerant with framework assemblies (which is typically what causes issues here). |
Related: dotnet/aspnetcore#43834 |
What would really help (IMO) is better diagnostic messaging when it fails. Saying the test failed with
Doesn't really tell a dev what is wrong. Instead, they need to pull the change locally, build, and run it themselves to figure out what is the issue/change. If instead the test failed with what files were missing / additional, that would really help diagnose what the change is that broke the test. For example, if the test failed with "Expected to have file |
This pull request updates the following dependencies
From https://github.com/dotnet/runtime