Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Console Logging test in NativeAOT #74381

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Enable Console Logging test in NativeAOT #74381

merged 2 commits into from
Aug 26, 2022

Conversation

eerhardt
Copy link
Member

Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled appears to be passing for me in NativeAOT on both Windows and Linux.

Contributes to #73436

@eerhardt
Enable Console Logging test in NativeAOT
090f52f 
Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled appears to be passing for me in NativeAOT on both Windows and Linux.

Contributes to dotnet#73436
@ghost
Copy link

ghost commented Aug 22, 2022

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled appears to be passing for me in NativeAOT on both Windows and Linux.

Contributes to #73436

Author: eerhardt
Assignees: -
Labels:

area-Extensions-Logging
Milestone: -

@ghost ghost assigned eerhardt Aug 22, 2022
@eerhardt
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
Copy link
Member Author

@MichalStrehovsky @LakshanF - how do I tell if the test in question ran? I don't see it failing on any legs, but I'm also not sure it passed on all the NativeAOT legs either.

@MichalStrehovsky MichalStrehovsky mentioned this pull request Aug 23, 2022
Closed
@MichalStrehovsky
Copy link
Member

@MichalStrehovsky @LakshanF - how do I tell if the test in question ran? I don't see it failing on any legs, but I'm also not sure it passed on all the NativeAOT legs either.

I think it's good. I spot checked one of the helix logs - https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-74381-merge-67c3cd974086489fa0/Microsoft.Extensions.Logging.Console.Tests/1/console.cb457c28.log?helixlogtype=result.

@eerhardt
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt eerhardt merged commit 4937707 into dotnet:main Aug 26, 2022
@eerhardt eerhardt deleted the EnableConsoleTest branch August 26, 2022 21:53
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LakshanF LakshanF LakshanF approved these changes

@tarekgh tarekgh tarekgh approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees

@eerhardt eerhardt

Labels
area-Extensions-Logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eerhardt @MichalStrehovsky @LakshanF @tarekgh