Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found in recent Int128 ABI change #74386

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Fix issues found in recent Int128 ABI change #74386

merged 2 commits into from
Aug 23, 2022

Conversation

davidwrighton
Copy link
Member

  • Crossgen2 compiler was failing to detect that structs containing Int128 needed marshalling
  • The contract we provide is that Int128 is aligned within a structure, but we do not provide guarantees around 128bit alignment itself, so the test needed updating for that.

Fixes #74318

@ghost ghost assigned davidwrighton Aug 22, 2022
@davidwrighton davidwrighton merged commit bd4bea6 into dotnet:main Aug 23, 2022
@akoeplinger
Copy link
Member

@davidwrighton I've seen this failing in 7.0-rc1 too, do you plan on backporting the fix?

@davidwrighton
Copy link
Member Author

@akoeplinger I plan to fix this in 7.0, but not port to 7.0-rc1 unless there is some specific ask to do so.

@davidwrighton
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2914908267

@github-actions github-actions bot mentioned this pull request Aug 23, 2022
Merged
@akoeplinger
Copy link
Member

That's fine by me, I just saw it failing in 7.0-rc1 as part of Test Monitor.

@karelz karelz mentioned this pull request Aug 25, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2022
@davidwrighton davidwrighton deleted the fix_74318 branch April 13, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@tannergooding tannergooding tannergooding approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@davidwrighton davidwrighton

Labels
area-TypeSystem-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure Interop/PInvoke/Int128/Int128TestFieldLayout/Int128TestFieldLayout.sh
5 participants
@davidwrighton @akoeplinger @jkoritzinsky @tannergooding @AaronRobinsonMSFT