[release/7.0] [NativeAOT] do not do shutdown for the main thread on Windows #74712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jkotas
approved these changes
Aug 27, 2022
|
Approved, signed off, CI green. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74679 to release/7.0
/cc @VSadov
Customer Impact
Lock-up at process exit.
The lock up is more likely to happen when process uses a lot of threads - like if running with ServerGC.
The issue here is that at some point in process shutdown some threads may be rudely terminated while holding thread store spinlock.
Yet the main thread (or more precisely the thread that initiated the shutdown) is still expected to exit normally. If this thread tries to take the TSL, the process locks up.
Testing
Stress-tested some library tests that are known to be affected via executing these tests hundreds of times in a loop with ServerGC/ConcurrentGC enabled.
Risk
Low for the currently supported scenarios.