[wasm] [debugger] First version of multithreaded debugging #74820

thaystg · 2022-08-30T16:08:25Z

cb1fd258-20f9-4648-89eb-78ddbd59a7d9.mp4

Build command:
.\build.cmd mono+libs -os browser /p:MonoWasmBuildVariant=multithread

Run debugger-tests command:
.\dotnet.cmd test src/mono/wasm/debugger/DebuggerTestSuite --filter DebuggerTests.MiscTests.TestDebugUsingMultiThreadedRuntime -e RuntimeConfiguration=Debug -e Configuration=Debug -e DebuggerHost=chrome -e WASM_TESTS_USING_VARIANT=multithreaded -e WasmEnableThreads=true

ghost · 2022-08-30T16:08:37Z

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

cb1fd258-20f9-4648-89eb-78ddbd59a7d9.mp4

Author:	thaystg
Assignees:	-
Labels:	`area-Debugger-mono`
Milestone:	-

…aystg/runtime into thays_support_multithreaded_debugging

thaystg · 2022-08-30T21:07:15Z

/azp run runtime-wasm

azure-pipelines · 2022-08-30T21:07:30Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-09-01T19:09:08Z

The Wasm.Build.Tests failures are #74944 .

src/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs

lambdageek

C code and TS code lgtm.

I'd like someone more familiar with the debug proxy to review that part

radical · 2022-09-27T04:12:54Z

needs to merge main

src/mono/wasm/debugger/BrowserDebugProxy/Firefox/FirefoxMonoProxy.cs

src/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs

src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs

src/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs

thaystg · 2023-01-30T15:11:30Z

/azp run runtime-wasm

azure-pipelines · 2023-01-30T15:11:42Z

Azure Pipelines successfully started running 1 pipeline(s).

thaystg · 2023-01-30T16:34:35Z

/azp run runtime-wasm

azure-pipelines · 2023-01-30T16:34:47Z

Azure Pipelines successfully started running 1 pipeline(s).

thaystg · 2023-01-30T17:54:47Z

/azp run runtime-wasm

azure-pipelines · 2023-01-30T17:54:59Z

Azure Pipelines successfully started running 1 pipeline(s).

thaystg · 2023-01-30T19:33:40Z

/azp run runtime-wasm-non-libtests

azure-pipelines · 2023-01-30T19:33:53Z

Azure Pipelines successfully started running 1 pipeline(s).

thaystg · 2023-01-31T01:06:42Z

/azp run runtime-wasm-non-libtests

azure-pipelines · 2023-01-31T01:06:57Z

Azure Pipelines successfully started running 1 pipeline(s).

thaystg · 2023-01-31T02:58:15Z

@radical @lambdageek Could you please do a final review so I can merge?

lambdageek

C and TypeScript lgtm. I tried to follow BrowserDebugProxy, but I'm not sure if I completely understand it

radical · 2023-02-01T18:21:39Z

eng/pipelines/runtime-wasm-dbgtests.yml

+#
+# Evaluate paths
+#
+- template: /eng/pipelines/common/evaluate-default-paths.yml


This is fine for now. But in a follow up we should change this to use these from runtime-extra-platforms-wasm.yml with a new debuggerTestsOnly parameter.

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml

radical · 2023-02-01T18:29:23Z

src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs

                    notifications.Remove(what, out _);
                    return tcs.Task;
                }

                throw new Exception($"Invalid internal state, waiting for {what} while another wait is already setup");
            }
+            else if (nextNotifications.TryDequeue(out var notification))


What if the next notification in the queue is for a different string what?

I'll push some changes and it will be throwing an exception if it's a different string what

radical · 2023-02-01T18:34:41Z

src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs

+                    await Client.SendCommand(sessionIdNewTarget, "Profiler.enable", null, token);
+                    await Client.SendCommand(sessionIdNewTarget, "Runtime.enable", null, token);
+                    await Client.SendCommand(sessionIdNewTarget, "Debugger.enable", null, token);
+                    await Client.SendCommand(sessionIdNewTarget, "Runtime.runIfWaitingForDebugger", null, token);
+                    await Client.SendCommand(sessionIdNewTarget, "Debugger.setAsyncCallStackDepth", JObject.FromObject(new { maxDepth = 32}), token);


For a follow up PR - the commands here, and in DebuggerTestBase.InitializeAsync should use the same base set of commands. And each case can add any additional ones as needed. Like the ones here seem to be the same.

Co-authored-by: Ankit Jain <radical@gmail.com>

…from the nextNotificationQueue.

thaystg · 2023-02-01T20:47:09Z

/azp run runtime-wasm-non-libtests

azure-pipelines · 2023-02-01T20:47:25Z

Azure Pipelines successfully started running 1 pipeline(s).

thaystg · 2023-02-01T20:51:11Z

/azp run runtime-wasm-non-libtests

azure-pipelines · 2023-02-01T20:51:30Z

Azure Pipelines successfully started running 1 pipeline(s).

First version of multithreaded debugging.

67331e6

dotnet-issue-labeler bot added the area-Debugger-mono label Aug 30, 2022

ghost assigned thaystg Aug 30, 2022

thaystg added 6 commits August 30, 2022 13:09

Merge branch 'main' into thays_support_multithreaded_debugging

38aa291

Revert package-lock.json

d84c33b

New line at package-lock.json

6c1925a

Fix not used variable.

fb7f67e

Fix debugger on firefox.

215bca6

Merge branch 'thays_support_multithreaded_debugging' of github.com:th…

015ff8d

…aystg/runtime into thays_support_multithreaded_debugging

thaystg requested a review from lambdageek August 30, 2022 21:12

thaystg added 3 commits September 1, 2022 13:29

Rewrite code to avoid duplicated code.

b028deb

Fix where mono_init_debugger_agent_common is called.

037c9f2

Remove whitespace.

df269dd

thaystg marked this pull request as ready for review September 1, 2022 16:53

thaystg requested review from radical, lewing, pavelsavara and marek-safar as code owners September 1, 2022 16:53

lambdageek mentioned this pull request Sep 2, 2022

[tracking] Experimental WebAssembly multithreading support #68162

Open

40 tasks

lambdageek reviewed Sep 12, 2022

View reviewed changes

src/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs Outdated Show resolved Hide resolved

lambdageek reviewed Sep 12, 2022

View reviewed changes

Merge branch 'main' into thays_support_multithreaded_debugging

bcf9257

radical reviewed Oct 7, 2022

View reviewed changes

src/mono/wasm/debugger/BrowserDebugProxy/Firefox/FirefoxMonoProxy.cs Show resolved Hide resolved

radical reviewed Oct 7, 2022

View reviewed changes

fix compilation for multithread runtime

a28845a

trying to fix multithread debugger tests on ci

0034d64

thaystg added 2 commits January 30, 2023 16:32

trying to fix debugger tests on ci

2635990

Merge branch 'dotnet:main' into thays_support_multithreaded_debugging

e22929e

build-analysis bot mentioned this pull request Jan 30, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

disabling tests on multithreaded runtime

33b6485

lambdageek approved these changes Jan 31, 2023

View reviewed changes

radical reviewed Feb 1, 2023

View reviewed changes

thaystg and others added 3 commits February 1, 2023 15:51

Update eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml

4cd3536

Co-authored-by: Ankit Jain <radical@gmail.com>

Merge branch 'dotnet:main' into thays_support_multithreaded_debugging

771d55b

Throwing an exception if the "what" is not the one that is being get …

c78ec41

…from the nextNotificationQueue.

thaystg merged commit ac18cc9 into dotnet:main Feb 1, 2023

build-analysis bot mentioned this pull request Feb 2, 2023

arm64 linux build machines seem to be missing key components? dotnet/arcade#12395

Closed

5 tasks

ghost locked as resolved and limited conversation to collaborators Mar 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] [debugger] First version of multithreaded debugging #74820

[wasm] [debugger] First version of multithreaded debugging #74820

thaystg commented Aug 30, 2022 •

edited

Loading

ghost commented Aug 30, 2022

thaystg commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

radical commented Sep 1, 2022

lambdageek left a comment

radical commented Sep 27, 2022

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

thaystg commented Jan 31, 2023

lambdageek left a comment

radical Feb 1, 2023

radical Feb 1, 2023

thaystg Feb 1, 2023

radical Feb 1, 2023

thaystg commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

thaystg commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

[wasm] [debugger] First version of multithreaded debugging #74820

[wasm] [debugger] First version of multithreaded debugging #74820

Conversation

thaystg commented Aug 30, 2022 • edited Loading

ghost commented Aug 30, 2022

thaystg commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

radical commented Sep 1, 2022

lambdageek left a comment

Choose a reason for hiding this comment

radical commented Sep 27, 2022

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 30, 2023

azure-pipelines bot commented Jan 30, 2023

thaystg commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

thaystg commented Jan 31, 2023

lambdageek left a comment

Choose a reason for hiding this comment

radical Feb 1, 2023

Choose a reason for hiding this comment

radical Feb 1, 2023

Choose a reason for hiding this comment

thaystg Feb 1, 2023

Choose a reason for hiding this comment

radical Feb 1, 2023

Choose a reason for hiding this comment

thaystg commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

thaystg commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

thaystg commented Aug 30, 2022 •

edited

Loading