Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Remove wbt manifest hack #75197

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 7, 2022

Now that the latest installer has the new manifest names

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Sep 7, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: lewing
Assignees: lewing
Labels:

area-Meta, new-api-needs-documentation

Milestone: -

@radical
Copy link
Member

radical commented Sep 7, 2022

The WBT failure here is due to network issues.

@carlossanlop
Copy link
Member

The WBT failure here is due to network issues.

Should the failed legs be restarted then? Several failed.

@carlossanlop
Copy link
Member

@marek-safar can we get an approval please?

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. Thanks for cleaning up this hack

@radical
Copy link
Member

radical commented Sep 7, 2022

@carlossanlop this is ready to go

@lewing lewing merged commit 4f686c2 into dotnet:release/7.0 Sep 7, 2022
@lewing lewing deleted the remove-wbt-manifest-hack branch September 7, 2022 23:16
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants