-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Update to latest .NET 7 Roslyn compiler #76471
Conversation
dotnet/roslyn#64093 This change enforced that `scoped` on a local set the escape scope to the current block where previously it was incorrectly setting to the containing method.
dotnet/roslyn#64318 This change allows anything returnable from a method to be assigned to an `out` parameter. In several places had to add `scoped` to `ref` to inform compiler they could not be captured in an `out` parameter.
dotnet/roslyn#64294 Compiler now issues warnings for pointer operations involving managed types
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsThis is a back port of #76459. The back port command failde due to merge conflicts hence this was created manually.
|
@jaredpar when/if this PR is ready, please request a code review sign-off, add the usual template descriptions (customer impact, testing, risks), apply the |
@carlossanlop .NET tactics has approved this change as it's follow up from compiler changes that went through approval. The need for this was asserted in the discussion and approved (assuming runtime had no push back on the changes).
How do I request sign off? |
It's usually the same folks who review the PR in main. So far, I see @stephentoub. |
BTW: this is a general policy going forward. Source build is now in sync with our product ship. That means whenever we make a toolset change, of which compiler is most prominent, that requires a code / build change in one of our repositories we must follow through with that change in impacted repositories. Failing to do so means source build cannot ship. Now when we take changes through .NET Tactics which we suspect will have downstream repo impact we get approval for both the toolset changes and the downstream repo change as a pair. During discussion we try and keep all three parties (toolset, repo owners and source build) involved. Happy to include anyone else to make sure things like this are well known as we take them for approval. 😄 |
Alright, so based on this, I'll apply the |
@stephentoub can you sign off on the backport of the change to |
CI green, signed off, approved by Tactics. Ready to merge. |
This is a back port of #76459.
The back port command failde due to merge conflicts hence this was created manually.