Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert frozen RuntimeType objects and write barriers for frozen objects" #76649

Merged
merged 29 commits into from
Oct 6, 2022
Merged

Revert "Revert frozen RuntimeType objects and write barriers for frozen objects" #76649

merged 29 commits into from
Oct 6, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Oct 5, 2022 •
edited
Loading

This PR reverts #76235 with a few manual modifications:

  1. JIT-EE guid is re-generated
  2. gen.bat is invoked (ThunkInput.txt)
  3. Crst are re-generated by the tool, changed lock-level to Unordered

The rest of the changes are automatically reverted.

The main issue why the initial PRs (#75573 and #76135) were reverted has just been resolved via #76251

tldr:
GC could collect some associated (with frozen objects) objects as unreachable, e.g. it could collect a SyncBlock, WeakReferences and Dependent handles associated with frozen objects which could (e.g. for a short period of time) be indeed unreachable but return back to life after.

Unblocks #76112

@ghost ghost assigned EgorBo Oct 5, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 5, 2022
@ghost
Copy link

ghost commented Oct 5, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR reverts #76235 with a few manual modifications:

  1. JIT-EE guid is re-generated
  2. gen.bat is invoked (ThunkInput.txt)
  3. Crst are re-generated by the tool, changed lock-level to Unordered
    The rest of the changes are automatically reverted.

The main issue why the initial PRs (#75573 and #76135) were reverted has just been resolved via #76251

tldr:
GC could collect some associated (with frozen objects) objects as unreachable, e.g. it could collect a SyncBlock, WeakReferences and Dependent handles associated with frozen objects which could (e.g. for a short period of time) be indeed unreachable but return back to life after.

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented Oct 5, 2022

/azp run runtime-coreclr outerloop, runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

EgorBo and others added 2 commits October 5, 2022 16:08
@EgorBo EgorBo marked this pull request as ready for review October 5, 2022 17:13
jkotas
jkotas reviewed Oct 5, 2022
View reviewed changes
src/coreclr/inc/corinfo.h Outdated Show resolved Hide resolved
@EgorBo @jkotas
Update src/coreclr/vm/jitinterface.cpp
cece178 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@EgorBo @jkotas
Update src/coreclr/vm/jitinterface.cpp
05cc624 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@EgorBo @jkotas
Update src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
2ea47b9 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

(I have not reviewed the superpmi files.)

EgorBo and others added 3 commits October 6, 2022 03:35
@build-analysis build-analysis bot mentioned this pull request Oct 6, 2022
Closed
@EgorBo EgorBo merged commit 23bdaa3 into dotnet:main Oct 6, 2022
@EgorBo
Copy link
Member Author

EgorBo commented Oct 6, 2022 •
edited
Loading

SPMI failures are expected (jit-ee guid change)
outerloop/gcstress passed (I assume changes we did for printobject could not brake anything additionally)
Thank you so much for help! 🙂

@EgorBo EgorBo deleted the foh-frozen-types-2 branch October 6, 2022 15:37
This was referenced Oct 13, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorBo @jkotas @jakobbotsch