Use DOTNET_ variables in tests

[am11]

Renamed COMPlus_ to DOTNET_ under src/tests, except for configuration tests.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Renamed COMPlus_ to DOTNET_ under src/tests, except for configuration tests.

Author:	am11
Assignees:	-
Labels:	area-CodeGen-coreclr, community-contribution
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Renamed COMPlus_ to DOTNET_ under src/tests, except for configuration tests.

Author:	am11
Assignees:	-
Labels:	area-Infrastructure, community-contribution
Milestone:	-

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Renamed COMPlus_ to DOTNET_ under src/tests, except for configuration tests.

Author:	am11
Assignees:	-
Labels:	area-Infrastructure-coreclr, community-contribution
Milestone:	-

[am11]

@ViktorHofer I used neutral infrastructure label as src/tests has tests for both runtimes, and DOTNET_ / COMPlus_ variables are handled by both with separate implementations (DOTNET_ is checked first and COMPlus is a legacy fallback, hence this PR).

[AaronRobinsonMSFT]

@am11 This is great. One concern I have is in superpmi - see below. I never updated this path because I wasn't sure all the scenarios and just haven't gotten back to it. @BruceForstall Can you provide some details on when the following is used? Does the JIT team use superpmi with the test suite that is being updated here?

runtime/src/coreclr/tools/superpmi/superpmi/jithost.cpp

Lines 10 to 46 in 6556178

	// Look for 'key' as an environment variable named COMPlus_<key>. The returned value
	// is nullptr if it is not found, or a string if found. If not nullptr, the returned
	// value must be freed with jitInstance.freeLongLivedArray(value).
	WCHAR* GetCOMPlusVariable(const WCHAR* key, JitInstance& jitInstance)
	{
	static const WCHAR Prefix[] = W("COMPlus_");
	static const size_t PrefixLen = (sizeof(Prefix) / sizeof(Prefix[0])) - 1;
	// Prepend "COMPlus_" to the provided key
	size_t keyLen = wcslen(key);
	size_t keyBufferLen = keyLen + PrefixLen + 1;
	WCHAR* keyBuffer =
	reinterpret_cast<WCHAR*>(jitInstance.allocateArray(sizeof(WCHAR) * keyBufferLen));
	wcscpy_s(keyBuffer, keyBufferLen, Prefix);
	wcscpy_s(&keyBuffer[PrefixLen], keyLen + 1, key);
	// Look up the environment variable
	DWORD valueLen = GetEnvironmentVariableW(keyBuffer, nullptr, 0);
	if (valueLen == 0)
	{
	jitInstance.freeArray(keyBuffer);
	return nullptr;
	}
	// Note this value must live as long as the jit instance does.
	WCHAR* value = reinterpret_cast<WCHAR*>(jitInstance.allocateLongLivedArray(sizeof(WCHAR) * valueLen));
	DWORD newValueLen = GetEnvironmentVariableW(keyBuffer, value, valueLen);
	jitInstance.freeArray(keyBuffer);
	if (valueLen < newValueLen)
	{
	jitInstance.freeLongLivedArray(value);
	return nullptr;
	}
	return value;
	}

[ghost]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Renamed COMPlus_ to DOTNET_ under src/tests, except for configuration tests.

Author:	am11
Assignees:	-
Labels:	area-Infrastructure, community-contribution
Milestone:	-

[am11]

@AaronRobinsonMSFT, those are defined in superpmi.py which I haven't changed.

[BruceForstall]

It's nice to move everything to our current recommended format.

I worry about how we can properly test this. We could easily lose coverage and not notice it.

In addition, there are other places that set/use COMPlus variables, e.g., src\coreclr\scripts, https://github.com/dotnet/jitutils

[danmoseley]

Dotnet/diagnostics also has a bunch, but the docs in some cases may apply also to older runtimes.

[BruceForstall]

LGTM

[BruceForstall]

@AaronRobinsonMSFT Do you want to review?

[am11]

@BruceForstall, #77025 is merged, I have pushed superpmi scripts change here. Also, there were few redundant exports which I've cleaned up. Please take another look. :)

[BruceForstall]

Additional changes LGTM; thanks for doing that.