-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move usages of COMPlus_
var to DOTNET_
fallback
#77239
Move usages of COMPlus_
var to DOTNET_
fallback
#77239
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for one thing.
c2ef3e7
to
0a47e9b
Compare
win-x64 test failure is unrelated gc assertion; #76801. @AaronRobinsonMSFT, what do you think about issuing an obsoletion notice as "warn once" (using a static variable) in this block: runtime/src/coreclr/utilcode/clrconfig.cpp Lines 661 to 664 in 4cbe6f9
By net10.0, we can remove the |
All for it but understanding how that works in practice is hard. It was in my original proposal for this work actually. Start reading at #47283 (comment). Unfortunately, I deleted the gist I wrote my proposal in, but the idea is captured in those comments. |
I'll try to look soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work.
Following up on #77025 for the remaining
COMPlus_
usages insrc/coreclr/{tools,nativeaot}
.