Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "_generated.*" suffix to some auto-generated files #77083

Merged
merged 12 commits into from
Oct 16, 2022
Merged

Add "_generated.*" suffix to some auto-generated files #77083

merged 12 commits into from
Oct 16, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Oct 15, 2022 •
edited
Loading

Contributes to #76184

This PR adds _generated.* suffix to the following auto-generated files:

src\coreclr\jit\ICorJitInfo_API_names.h
src\coreclr\jit\ICorJitInfo_API_wrapper.hpp
src\coreclr\tools\Common\JitInterface\CorInfoBase.cs

This slightly helps to ignore files during JIT-EE API modifications.
Also, this PR fixes gen.bat that used to insert two empty lines in the end of CorInfoBase.cs

@ghost ghost assigned EgorBo Oct 15, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 15, 2022
@ghost
Copy link

ghost commented Oct 15, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This slightly helps to ignore files during JIT-EE API modifications.
Also, this PR fixes gen.bat that used to insert two empty lines in the end of CorInfoBase.cs

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo EgorBo mentioned this pull request Oct 15, 2022
Open
6 tasks
jkotas
jkotas approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@EgorBo @jkotas
Update docs/project/updating-jitinterface.md
3d9e599 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@jkotas jkotas merged commit 9e7a8a1 into dotnet:main Oct 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @jkotas