Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix regression when serializing untyped polymorphic root-level custom converters. #77388

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2022

Backport of #77186 to release/7.0

/cc @eiriktsarpalis

Customer Impact

Fixes a user reported regression from .NET 6 which impacts support for custom polymorphic converters when used in specific contexts (root-level untyped serialization).

Testing

Added regression testing covering the particular regression and other similar cases.

Risk

Low. Product code reinstates a change that was made in the context of a wider refactoring.

@ghost
Copy link

ghost commented Oct 24, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #77186 to release/7.0

/cc @eiriktsarpalis

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis self-assigned this Oct 24, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.1 milestone Oct 24, 2022
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial change LGTM.
Packaging diff looks correct. cc @carlossanlop

@eiriktsarpalis
Copy link
Member

I think this could be merged now?

@carlossanlop
Copy link
Member

The branch is open for changes now that we merged the branding PR.

OOB package authoring changes look good. Congrats on being the first OOB servicing package we merge for 7.0.1 😄 .

Approved by Tactics. Signed off by area owner. CI is green.

Ready to merge. :shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change: Untyped Deserialize no longer forwards the type to JsonConverter<T>
4 participants