-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Fix regression when serializing untyped polymorphic root-level custom converters. #77388
Conversation
… converters. Fix #77173.
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #77186 to release/7.0 /cc @eiriktsarpalis Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial change LGTM.
Packaging diff looks correct. cc @carlossanlop
I think this could be merged now? |
The branch is open for changes now that we merged the branding PR. OOB package authoring changes look good. Congrats on being the first OOB servicing package we merge for 7.0.1 😄 . Approved by Tactics. Signed off by area owner. CI is green. Ready to merge. |
Backport of #77186 to release/7.0
/cc @eiriktsarpalis
Customer Impact
Fixes a user reported regression from .NET 6 which impacts support for custom polymorphic converters when used in specific contexts (root-level untyped serialization).
Testing
Added regression testing covering the particular regression and other similar cases.
Risk
Low. Product code reinstates a change that was made in the context of a wider refactoring.