Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] Ensure ReadBufferState resets any BOM offsets every time the buffer is advanced. #78235

Merged
merged 3 commits into from
Nov 11, 2022
Merged

[release/7.0] Ensure ReadBufferState resets any BOM offsets every time the buffer is advanced. #78235

merged 3 commits into from
Nov 11, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 11, 2022 •
edited by eiriktsarpalis
Loading

Backport of #78221 to release/7.0

/cc @eiriktsarpalis

Customer Impact

Addresses an issue reported by a partner team. A change in #70430 regressed BOM handling in async deserialization, which under certain circumstances can result in a small number of bytes being skipped by the reader.

Testing

Added a regression covering the reported issues. Updates the async serialization stress testing harness so that the BOM character is injected in payloads.

Risk

Low. Makes a targeted change to production code addressing the bug in question.

@eiriktsarpalis eiriktsarpalis self-assigned this Nov 11, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.x milestone Nov 11, 2022
@eiriktsarpalis eiriktsarpalis added the Servicing-consider Issue for next servicing release review label Nov 11, 2022
@ghost
Copy link

ghost commented Nov 11, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78221 to release/7.0

/cc @eiriktsarpalis

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Nov 11, 2022
Closed
@eiriktsarpalis eiriktsarpalis added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 11, 2022
@eiriktsarpalis
Copy link
Member

Approved by Tactics over email.

@carlossanlop
Copy link
Member

carlossanlop commented Nov 11, 2022 •
edited
Loading

Approved by Tactics and signed off.
CI failure is known and unrelated: #77988
This change needs OOB package authoring changes but they have already been merged into release/7.0 in a previous fix that also needs to go into 7.0.1:

runtime/src/libraries/System.Text.Json/src/System.Text.Json.csproj

Lines 10 to 12 in 9e7c283

<IsPackable>true</IsPackable>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<ServicingVersion>1</ServicingVersion>

Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 1c341de into release/7.0 Nov 11, 2022
@carlossanlop carlossanlop deleted the backport/pr-78221-to-release/7.0 branch November 11, 2022 22:56
@steveharter steveharter self-requested a review November 12, 2022 15:38
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@steveharter steveharter Awaiting requested review from steveharter

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json Servicing-approved Approved for servicing release
Projects
None yet
Milestone
7.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@eiriktsarpalis @carlossanlop