-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Remove repeated calls to beginHandshake #78849
[Android] Remove repeated calls to beginHandshake #78849
Conversation
Cleanup Revert some changes
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsOn legacy Android APIs (26 and earlier) the There's a related problem: during the handshake process, the SSLSession isn't accessible and it's necessary to call the Closes #78716
|
/azp run runtime-android |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-androidemulator |
Azure Pipelines successfully started running 1 pipeline(s). |
CI failures are unrelated to this PR. |
/backport to release/7.0 |
/backport to release/6.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3584440281 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3584441419 |
Cleanup Revert some changes
Cleanup Revert some changes
On legacy Android APIs (26 and earlier) the
SSLEngine.beginHandshake()
Java method cannot be called when the handshake has already been started. This has been fixed in later Android revisions (which we use in CI).There's a related problem: during the handshake process, the SSLSession isn't accessible and it's necessary to call the
SSLEngine.getHandshakeSession()
to get the reference to the session that's being constructed (see https://developer.android.com/reference/javax/net/ssl/SSLSocket#getHandshakeSession() for more info). That prompted several other changes in thepal_sslstream.c
.This PR fixes
SslStream
on Android APIs 24-26.Closes #78716
Related to #77386