Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put back setting of field in DirectorySearcher.FindAll #79093

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Put back setting of field in DirectorySearcher.FindAll #79093

merged 1 commit into from
Dec 1, 2022

Conversation

stephentoub
Copy link
Member

This was removed accidentally due to erroneously thinking it was a local rather than a field.
Reverts most of dotnet/corefx#40321
Fixes #79066

@stephentoub
Put back setting of field in DirectorySearcher.FindAll
e66244e 
This was removed accidentally due to erroneously thinking it was a local rather than a field.
@ghost ghost assigned stephentoub Dec 1, 2022
@ghost
Copy link

ghost commented Dec 1, 2022

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

Issue Details

This was removed accidentally due to erroneously thinking it was a local rather than a field.
Reverts most of dotnet/corefx#40321
Fixes #79066

Author: stephentoub
Assignees: -
Labels:

area-System.DirectoryServices
Milestone: -

MihaZupan
MihaZupan approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate field naming :/

@stephentoub stephentoub merged commit 320f1e1 into dotnet:main Dec 1, 2022
@stephentoub stephentoub deleted the fixdirectorysync branch December 1, 2022 17:37
@marek-safar
Copy link
Contributor

Why not to backport this?

@stephentoub
Copy link
Member Author

We could. We've just had one comment about it in three years. This shipped in .NET 5.

@akoeplinger
Copy link
Member

@stephentoub I think we also got a comment in #47169 (comment)

It does sound like a backport candidate to me.

@stephentoub
Copy link
Member Author

/backport to release/7.0

@stephentoub
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3608961498

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3608962541

@stephentoub
Copy link
Member Author

@stephentoub I think we also got a comment in #47169 (comment)

It does sound like a backport candidate to me.

Thanks. So it's that issue now fixed in main as well?

This was referenced Dec 3, 2022
Merged
Merged
@akoeplinger
Copy link
Member

Yes, I tested and it fixes that issue in main.

@akoeplinger akoeplinger mentioned this pull request Dec 5, 2022
Closed
@stephentoub
Copy link
Member Author

Thanks for validating that.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

@joperezr joperezr Awaiting requested review from joperezr

Assignees

@stephentoub stephentoub

Labels
area-System.DirectoryServices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken DirectorySearch DirectorySynchronization
4 participants
@stephentoub @marek-safar @akoeplinger @MihaZupan