Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Put back setting of field in DirectorySearcher.FindAll #79192

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2022

Backport of #79093 to release/7.0

/cc @stephentoub

Customer Impact

Various aspects of LDAP directory searching using DirectorySearcher / DirectorySynchronization are broken, e.g. number of results reported might be 0 even when it's not, search results that should have been cached aren't, etc. We inadvertently removed a few lines of code that stored the result of a search for later use.

Testing

Existing tests.

Risk

Minimal. We're just reverting a few lines that were removed erroneously.

This was removed accidentally due to erroneously thinking it was a local rather than a field.
@ghost
Copy link

ghost commented Dec 3, 2022

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79093 to release/7.0

/cc @stephentoub

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.DirectoryServices

Milestone: -

@stephentoub stephentoub added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 4, 2022
@stephentoub stephentoub added this to the 7.0.x milestone Dec 5, 2022
@carlossanlop carlossanlop modified the milestones: 7.0.x, 7.0.3 Jan 4, 2023
@carlossanlop
Copy link
Member

carlossanlop commented Jan 4, 2023

@stephentoub since this is an OOB package, I added the missing change to the src csproj.

@carlossanlop
Copy link
Member

Approved by Tactics for 7.0.3.
Signed off by area owner.
OOB package changes added.
Waiting for CI to finish, but the last run hit the known and unrelated failure #78778 (already fixed in the 7.0 branch).

@carlossanlop
Copy link
Member

CI failure is unrelated (networking infra problem). Reported the failures here: #75611

@carlossanlop carlossanlop merged commit 4553b81 into release/7.0 Jan 5, 2023
@carlossanlop carlossanlop deleted the backport/pr-79093-to-release/7.0 branch January 5, 2023 18:33
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants