Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RhpGetTickCount64: set the return type to match the definition in InternalCalls.cs #79538

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

yowl
Copy link
Contributor

@yowl yowl commented Dec 12, 2022

This PR fixes a mismatch in the return type for this function between the cpp implementation in MiscHelpers.cpp and the extern import in InternalCalls.cs where it is:

[DllImport(Redhawk.BaseName, CallingConvention = CallingConvention.Cdecl)]
internal static extern ulong RhpGetTickCount64();

The mismatch is a problem in the runtimelab NativeAOT-LLVM experiment where the linker, wasm-ld, complains and fails.

Return type changed from void to uint64_t.

Thanks,

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fixes a mismatch in the return type for this function between the cpp implementation in MiscHelpers.cpp and the extern import in InternalCalls.cs where it is:

[DllImport(Redhawk.BaseName, CallingConvention = CallingConvention.Cdecl)]
internal static extern ulong RhpGetTickCount64();

The mismatch is a problem in the runtimelab NativeAOT-LLVM experiment where the linker, wasm-ld, complains and fails.

Return type changed from void to uint64_t.

Thanks,

Author: yowl
Assignees: -
Labels:

community-contribution, area-NativeAOT-coreclr

Milestone: -

@jkotas
Copy link
Member

jkotas commented Dec 12, 2022

All known errors according to the build analysis

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit ddb91f5 into dotnet:main Dec 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants