Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix up NativeAOT testing" & don't build clr.runtime for libraries AOT tests #79637

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Revert "Fix up NativeAOT testing" & don't build clr.runtime for libraries AOT tests #79637

merged 2 commits into from
Dec 14, 2022

Conversation

ViktorHofer
Copy link
Member

Follow-up on #79595 (comment) and 866f3eb

@ViktorHofer
Revert "Fix up NativeAOT testing (dotnet#79523)"
32ab75e 
This reverts commit b2bebcb.
@ViktorHofer
Don't build clr.runtime for libraries AOT tests
1b3f497 
866f3eb made it again possible to build
the host.native subset without the clr.runtime. Previously there was a
dependency on the singlefilehost which was removed when it isn't
required.
@ViktorHofer ViktorHofer self-assigned this Dec 14, 2022
@ViktorHofer ViktorHofer changed the title Revert "Fix up NativeAOT testing & Don't build clr.runtime for libraries AOT tests Revert "Fix up NativeAOT testing" & Don't build clr.runtime for libraries AOT tests Dec 14, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up on #79595 (comment) and 866f3eb

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure
Milestone: -

@ViktorHofer ViktorHofer changed the title Revert "Fix up NativeAOT testing" & Don't build clr.runtime for libraries AOT tests Revert "Fix up NativeAOT testing" & don't build clr.runtime for libraries AOT tests Dec 14, 2022
This was referenced Dec 14, 2022
Closed
Closed
Closed
jkotas
jkotas approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ViktorHofer ViktorHofer merged commit f7f0e0a into dotnet:main Dec 14, 2022
@ViktorHofer ViktorHofer deleted the AOTWorkaroundRemoval branch December 14, 2022 20:01
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @jkotas