Pass metadata pointers to RyuJIT #79806
Merged
+64
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyuJIT started asking about names a lot more than it used to. Pass it UTF-8 pointers from metadata instead of UTF-16-converted, then UTF-8 converted, and pinned byte buffers.
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsRyuJIT started asking about names a lot more than it used to. Pass it UTF-8 pointers from metadata instead of UTF-16-converted, then UTF-8 converted, and pinned byte buffers. Gets rid of a couple
I did the minimal amount of work necessary to do this, but we might have an opportunity to switch more of the type system to the Utf8 plan (with UTF8 string literals support arriving in .NET 7, we probably have all the primitives we could get). Just not sure this is what I should spend more time on right now. Cc @dotnet/ilc-contrib
|
This was referenced Dec 19, 2022
jkotas
approved these changes
Dec 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RyuJIT started asking about names a lot more than it used to. Pass it UTF-8 pointers from metadata instead of UTF-16-converted, then UTF-8 converted, and pinned byte buffers.
Gets rid of a couple
byte[]allocations (this is from a hello world):I did the minimal amount of work necessary to do this, but we might have an opportunity to switch more of the type system to the Utf8 plan (with UTF8 string literals support arriving in .NET 7, we probably have all the primitives we could get). Just not sure this is what I should spend more time on right now.
Cc @dotnet/ilc-contrib